Require release flags in breeze helm chart issue command #51815
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedcunningham
requested review from
amoghrajesh,
ashb,
gopidesupavan,
kaxil,
pierrejeambrun and
potiuk
as code owners
eladkal
approved these changes
Jun 16, 2025
amoghrajesh
previously approved these changes
Jun 17, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM but theres a strange CI error. Lmk if you need help
potiuk
approved these changes
Jun 17, 2025
amoghrajesh
reviewed
Jun 17, 2025
dev/breeze/src/airflow_breeze/commands/release_management_commands.py
Outdated
Show resolved
Hide resolved
pierrejeambrun
approved these changes
Jun 17, 2025
amoghrajesh
approved these changes
Jun 18, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
LGTM +1
Failures arent related
This was removed in apache#50464, but we still need to do this step.
jedcunningham
force-pushed
the
fix_helm_chart_release_guide
branch
from
93304c8 to
6b40d63
Compare
Member
Author
|
Oops, thought this was merged and repurposed this branch for another change 😓. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need these, so fail early if they are missing (say, you missed escaping a newline 😂).